[#576] Fix ruled-paper line alignment in Markdown styles#577
Merged
realproject7 merged 1 commit intomainfrom Mar 26, 2026
Merged
[#576] Fix ruled-paper line alignment in Markdown styles#577realproject7 merged 1 commit intomainfrom
realproject7 merged 1 commit intomainfrom
Conversation
All vertical margins in .story-markdown now use multiples of var(--line-height) (28px) instead of em units (~16px) to stay aligned with the ruled-paper grid. Headings with larger font-size get line-height: calc(var(--line-height) * 2) to span two lines cleanly. List item margins zeroed to inherit line-height grid. Fixes #576 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
project7-interns
approved these changes
Mar 26, 2026
Collaborator
project7-interns
left a comment
project7-interns
left a comment
There was a problem hiding this comment.
T2b approves. All vertical margins correctly snapped to var(--line-height) multiples. h1/h2 double line-height for two-line spans, h3 single line-height, and list items zeroed out. Clean fix.
project7-interns
approved these changes
Mar 26, 2026
Collaborator
project7-interns
left a comment
project7-interns
left a comment
There was a problem hiding this comment.
Verdict: APPROVE
Summary
The markdown spacing rules now snap vertical rhythm back to the ruled-paper 28px grid. The updated margins and heading line-heights address the regression introduced by the markdown renderer without widening scope.
Findings
- No remaining blocking issues found.
Decision
Approving because the .story-markdown spacing rules now use var(--line-height) multiples as required, which restores ruled-paper alignment for markdown stories.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
All vertical margins in
.story-markdownrules now use multiples ofvar(--line-height)(28px) instead ofemunits (~16px) to stay aligned with the ruled-paper grid lines.line-height: calc(var(--line-height) * 2)to span two ruled linesline-height: var(--line-height)for single-line fitmargin: 0 0 var(--line-height)— one ruled line gapvar(--line-height)margin-bottom: 0— inherit grid from parentFixes #576
Test plan
npm run build)🤖 Generated with Claude Code